[hafqa] [hafqa] [Bug 814] INVALID_CHAR defined twice

[From: bugzilla-daemon at maemo.org]

https://maemo.org/bugzilla/show_bug.cgi?id=814





------- Additional Comments From murrayc at murrayc.com  2006-11-07 20:02 -------
This seems like the easiest patch to apply, but ideally, instead of this:
 
 typedef enum
 {
-  NO_ERROR = -1,
+  NO_DATE_ERROR = -1,
   MAX_DAY,
   MAX_MONTH,
   MAX_YEAR,
@@ -74,7 +74,7 @@
   EMPTY_MONTH,
   EMPTY_YEAR,
   INVALID_DATE,
-  INVALID_CHAR
+  INVALID_DATE_CHAR
     
 }HildonDateEditorErrorType;

shouldn't it be like this to avoid future conflicts, and to be more consistent
with other G APIs?:

 typedef enum
 {
   HILDON_DATE_EDITOR_ERROR_NO_DATE_ERROR = -1,
   ...
   HILDON_DATE_EDITOR_ERROR_INVALID_DATE_CHAR
     
 }HildonDateEditorErrorType;


If the maintainer says he will accept that, please provide a patch for that or
similar.


-- 
Configure bugmail: https://maemo.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.