[hafqa] [hafqa] [Bug 856] Sapwood crashes with color depth != 16

[From: bugzilla-daemon at maemo.org]

https://maemo.org/bugzilla/show_bug.cgi?id=856





------- Additional Comments From tommi.komulainen at nokia.com  2006-11-22 18:11 -------
(From update of attachment 143)
I was thinking about using the depth from the (default) root window, but
according to Daniel there's no big difference, unless you run Composite.
However, please follow the existing coding style.

>+int get_display_depth ()
>+{
>+  GdkScreen * screen = NULL;
>+  GdkVisual * system_visual = NULL;

note the whitespace


>+  screen = gdk_screen_get_default();
>+  if (!screen)
>+    return SAPWOOD_SERVER_DEFAULT_DEPTH;

This should be g_assert if you want to check anything -- if there is no default
display, things are pretty broken already.


>+  system_visual = gdk_screen_get_system_visual(screen);
>+  if (!system_visual)

gdk_screen_get_system_visual can not return NULL when screen is valid.


>+  server_depth = get_display_depth();

whitespace


-- 
Configure bugmail: https://maemo.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.