[hafqa] [hafqa] [Bug 874] hildon_file_details_dialog_new_with_model() should just call g_object_new()

[From: bugzilla-daemon at maemo.org]

https://maemo.org/bugzilla/show_bug.cgi?id=874


marius.vollmer at nokia.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From marius.vollmer at nokia.com  2006-11-22 19:17 -------
Ok, I made the following change.  Is that what you had in mind?  I think the
call to gtk_window_set_transient_for is OK, right?

This change will be in hildon-fm 2.1, in Sardine.

	* hildon-fm/hildon-file-details-dialog.c
	(hildon_file_details_dialog_init): Set default title here.
	(hildon_file_details_dialog_new)
	(hildon_file_details_dialog_new_with_model): Don't set it here.

Index: hildon-fm/hildon-file-details-dialog.c
===================================================================
--- hildon-fm/hildon-file-details-dialog.c	(revision 7402)
+++ hildon-fm/hildon-file-details-dialog.c	(working copy)
@@ -466,6 +466,8 @@
 				  GTK_WIDGET(priv->notebook), &geometry,
 				  GDK_HINT_MIN_SIZE | GDK_HINT_MAX_SIZE);
 
+    gtk_window_set_title (GTK_WINDOW (self), _("sfil_ti_file_details"));
+			  
     gtk_widget_show_all(GTK_WIDGET(priv->notebook));
 
     priv->ok_button = gtk_dialog_add_button(GTK_DIALOG(self),
@@ -651,8 +653,7 @@
 
   dialog =
         g_object_new(HILDON_TYPE_FILE_DETAILS_DIALOG, 
-          "has-separator", FALSE, "title", _("sfil_ti_file_details"), 
-          "model", model, NULL);
+          "has-separator", FALSE, "model", model, NULL);
 
   if (filename && filename[0] && 
     hildon_file_system_model_load_local_path(dialog->priv->model, filename, &iter))
@@ -681,8 +682,7 @@
   GtkWidget *dialog;
 
   dialog = g_object_new(HILDON_TYPE_FILE_DETAILS_DIALOG,
-    "has-separator", FALSE, "title", _("sfil_ti_file_details"), 
-    "model", model, NULL);
+    "has-separator", FALSE, "model", model, NULL);
 
   if (parent)
     gtk_window_set_transient_for(GTK_WINDOW(dialog), parent);


-- 
Configure bugmail: https://maemo.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.