[hafqa] [hafqa] [Bug 2396] mouseup outside of a textarea while selecting text should not trigger any click events to elements outside the textarea

[From: bugzilla-daemon at lists.maemo.org]

https://bugs.maemo.org/show_bug.cgi?id=2396


timeless at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|mdamt at maemo.org             |nobody at maemo.org
          Component|Input method framework      |MicroB engine
            Product|System software             |Browser
          QAContact|input-method-framework-     |microb-bugs at maemo.org
                   |bugs at maemo.org              |
            Summary|selecting text in browser   |mouseup outside of a
                   |input field makes the       |textarea while selecting
                   |keyboard go away            |text should not trigger any
                   |                            |click events to elements
                   |                            |outside the textarea




------- Comment #3 from timeless at gmail.com  2007-12-02 21:39 GMT+3 -------
steps to find the buggy code:
1. assume it's a ui bug, browse through to:
http://timeless.justdave.net/mxr-test/garage/source/browser/browser-ui/trunk/tablet-browser-ui/src/
2. 
Search for: [_im_             ] within this directory [ search ]
fill in search value (_im_) and click search
2' the results include gtk_im_context_show, so that's probably close to what
we're interested in.
3. Search for: [gtk_im_context            ] [ search ]
        [ ] Regular Expression Search
        [ ] Case sensitive
in files matching: [/browser/.*\.c$ ]
(fill in gtk_im_context and /browser/.*\.c$, then search)
4. there's only one hit for hide:
/browser/mozilla/trunk/microb-eal/src/gmozillaengine.c, 
line 2280 -- hildon_gtk_im_context_hide (im);

http://timeless.justdave.net/mxr-test/garage/source/browser/mozilla/trunk/microb-eal/src/gmozillaengine.c#2280
2247 static gboolean
2248 vkb_handle_action(GMozillaEngine *self, guint moz_embed_ctx, GdkEventKey *
event)
2253     im = register_im_context(self);
2254     gboolean show_vkb = TRUE;
2255     
2256     if (event && (event->keyval != GDK_Return))
2278     } else {
2279         if (!(moz_embed_ctx & GTK_MOZ_EMBED_CTX_XUL)) {
2280              hildon_gtk_im_context_hide (im);

This is the buggy code.

>From this, it's clear the bug is browser's fault.

Dealing it requires a more complicated state machine (namely we really do need
to remember where the mouse down event happened).

searching through the file:
2229         g_signal_connect(G_OBJECT(child), "button_press_event",
2230                            G_CALLBACK(gdk_press_event_cb), self);
2231         g_signal_connect(G_OBJECT(child), "button_release_event",
2232                            G_CALLBACK(gdk_release_event_cb), self);
seems to be the registration, and
1919 gdk_press_event_cb (GtkWidget *embed, GdkEventButton *event,
1935 gdk_release_event_cb (GtkWidget *embed, GdkEventButton *event,
seem to be the implementations.


-- 
Configure bugmail: https://bugs.maemo.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
You are the QA contact for the bug, or are watching the QA contact.