[hafqa] [hafqa] [Bug 823] support for Hildon specific hacks to GTK+ should be conditional

[From: bugzilla-daemon at maemo.org]

https://maemo.org/bugzilla/show_bug.cgi?id=823





------- Additional Comments From tommi.komulainen at nokia.com  2007-02-07 14:14 -------
If you do not define MAEMO_CHANGES the added functions, enums, function pointers
will not be available and if you try to use them the compilation will fail. It
does not catch property access, though (they probably should be encapsulated in
functions)

What Johan's patch does is to remove any attempts to use our extended
functionality so that hildon can be compiled against stock gtk (or maemo gtk
without MAEMO_CHANGES)

I think we should have --enable-gtk-extensions[=yes/no/auto] configure flag
(default=auto) which would determine whether MAEMO_CHANGES gets defined (while
building as well as in the pkgconfig file) and our gtk extensions are even
attempted to be used.

Did that make any sense?


btw, GDK_WINDOW_TYPE_HINT_MESSAGE should be replaced with
GDK_WINDOW_TYPE_HINT_NOTIFICATION as soon as we have matchbox which supports the
hint. That would be one patch/conditional less.

-- 
Configure bugmail: https://maemo.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.