[hafqa] [hafqa] [Bug 2070] When applicationn lasts on respond, long ESC keypress could not work or short ESC keypress could close the app.

[From: bugzilla-daemon at lists.maemo.org]

https://bugs.maemo.org/show_bug.cgi?id=2070





------- Comment #4 from agomez at igalia.com  2007-10-15 20:26 GMT+3 -------
(in reply to comment #3)
> - In the future could you use -p for the diff command? It makes reading patches
> easier, as it gives more context.

Thanks for the tip!

> This on the other hand, I'm not so sure. It is a hack, and I can imagine
> situations where it could break (like getting a ButtonRelease without a
> ButtonPress. Yes, it can happen). Shouldn't lowering the priority of the
> timeout  be enough to prevent it from running before queued events that got
> stuck because the application is blocking the main loop?

You are right, this is a hack but this is not new code. It has been
refactored from the hildon_window_escape_timeout function in order to
make use of it more easily.

About those situations, they are already handled, take a look to the
hildon_window_focus_out_event function.

Finally, I reckon it is not enough just lowering the priority since
you have to handle with key release event been handled before timeout
and having pressed the key for more than the set timeout.

I think the patch is safe in the sense that it is not adding any
strange hack that it wasn't already there.


-- 
Configure bugmail: https://bugs.maemo.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.