[hafqa] [hafqa] [Bug 3583] New: libhildonmime fails to build due to variable format strings

[From: bugzilla-daemon at maemo.org]

https://bugs.maemo.org/show_bug.cgi?id=3583

           Summary: libhildonmime fails to build due to variable format
                    strings
           Product: System software
           Version: unspecified
          Platform: All
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Low
         Component: general
        AssignedTo: nobody at maemo.org
        ReportedBy: lool at dooz.org
         QAContact: hafqa at maemo.org


Hi,

libhildonmime fails to build with some -Wformat* gcc flag which is in use in
Ubuntu by default (for security purposes):
/bin/bash ../libtool --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I..
-I../libhildonmime -DPREFIX=\"/usr\"
-DGLOBS_FILE_PATH=\"/usr/share/mime/globs\" -Wall -Wunused -Wchar-subscripts
-Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith
-Wno-sign-compare -Wno-pointer-sign -Werror  -pthread -DORBIT2=1
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
-I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include
-I/usr/include/gconf/2 -I/usr/include/orbit-2.0
-I/usr/include/gnome-vfs-module-2.0 -I/usr/include/dbus-1.0
-I/usr/lib/dbus-1.0/include   -g -O2 -g -O2 -MT libhildonmime_la-hildon-uri.lo
-MD -MP -MF .deps/libhildonmime_la-hildon-uri.Tpo -c -o
libhildonmime_la-hildon-uri.lo `test -f 'hildon-uri.c' || echo
'./'`hildon-uri.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I../libhildonmime
-DPREFIX=\"/usr\" -DGLOBS_FILE_PATH=\"/usr/share/mime/globs\" -Wall -Wunused
-Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -Wnested-externs
-Wpointer-arith -Wno-sign-compare -Wno-pointer-sign -Werror -pthread -DORBIT2=1
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
-I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include
-I/usr/include/gconf/2 -I/usr/include/orbit-2.0
-I/usr/include/gnome-vfs-module-2.0 -I/usr/include/dbus-1.0
-I/usr/lib/dbus-1.0/include -g -O2 -g -O2 -MT libhildonmime_la-hildon-uri.lo
-MD -MP -MF .deps/libhildonmime_la-hildon-uri.Tpo -c hildon-uri.c  -fPIC -DPIC
-o .libs/libhildonmime_la-hildon-uri.o
cc1: warnings being treated as errors
hildon-uri.c: In function ‘hildon_uri_get_scheme_from_uri’:
hildon-uri.c:1714: error: format not a string literal and no format arguments
hildon-uri.c: In function ‘hildon_uri_open’:
hildon-uri.c:2295: error: format not a string literal and no format arguments
hildon-uri.c:2351: error: format not a string literal and no format arguments
hildon-uri.c:2379: error: format not a string literal and no format arguments
make[3]: *** [libhildonmime_la-hildon-uri.lo] Erreur 1


This is because of calls to printf with a variable string as argument.

I'll attach the patch we use to fix the build for us.

I checked the relevant code, and the strings in use are fine; there's probably
no security issue here.

Bye,


-- 
Configure bugmail: https://bugs.maemo.org/userprefs.cgi?tab=email
Replies to this email are NOT read, instead please add comments at
https://bugs.maemo.org/show_bug.cgi?id=3583
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.