[maemo-commits] [maemo-commits] /trunk/hildon-libs/ - luc - r2825

[From: www-data]

        Volume bars cleanup

        * hildon-widgets/hildon-volumebar.c
        (hildon_volumebar_class_init): object class casts cleaned up
        (hildon_child_forall): removed unnecessary variable vbar; type check added
        (hildon_volumebar_set_property): removed unnecessary variable vbar
        (hildon_volumebar_set_level): type check added
        (hildon_volumebar_get_level): type check added
        (hildon_volumebar_set_mute): type check added
        (hildon_volumebar_get_mute): type check added
        (hildon_volumebar_get_adjustment): type check added
        (hildon_volumebar_key_press): removed unnecessary g_return_if_fail

        * hildon-widgets/hildon-volumebar.h
        (hildon_volumebar_get_type): declared G_GNUC_CONST

        * hildon-widgets/hildon-volumebar-private.h:
        - G_BEGIN_DECLS/G_END_DECLS added
        - ownorientation removed from private struct

        * hildon-widgets/hildon-volumebar-range.c
        (hildon_volumebar_range_init): vacuous return statement removed

        (hildon_volumebar_range_set_level): removed unnecessary clamping
        kludge that violated object oriented principles only to provide an
        extremely minor, unnecessary optimization; type check added

        (hildon_volumebar_range_get_level): now accesses adjustment value
        with appropriate functions instead of reading it directly from the
        struct, which is bad OOP; type check added

        (hildon_volumebar_range_button_press_event): Added more descriptive comments
        (hildon_volumebar_range_button_release_event): Added more descriptive comments

        * hildon-widgets/hildon-volumebar-range.h
        (hildon_volumebar_range_get_type): declared G_GNUC_CONST

        * hildon-widgets/hildon-hvolumebar.c
        (hvolumebar_init): priv->ownorientation and v_ptr removed;
        completely removed the gtk_widget_show() call that was already
        commented out

        (hildon_hvolumebar_new): empty function parameter list replaced
        with void keyword

        (hildon_hvolumebar_map): vbar variable removed; type check added
        (hildon_hvolumebar_expose): type check added
        (hildon_hvolumebar_size_request): type check added
        (hildon_hvolumebar_size_allocate): vbar variable removed; type check added

        * hildon-widgets/hildon-hvolumebar.h
        (hildon_hvolumebar_get_type): declared G_GNUC_CONST

        * hildon-widgets/hildon-vvolumebar.c
        (vvolumebar_init): priv->ownorientation and v_ptr removed
        (hildon_vvolumebar_new): empty function parameter list replaced with void keyword

        (hildon_vvolumebar_expose): type check added
        (hildon_vvolumebar_size_request): type check added
        (hildon_vvolumebar_size_allocate): vbar variable removed; type check added

        * hildon-widgets/hildon-vvolumebar.h
        (hildon_vvolumebar_get_type): declared G_GNUC_CONST

M    hildon-widgets/hildon-volumebar.c
M    hildon-widgets/hildon-volumebar.h
M    hildon-widgets/hildon-vvolumebar.c
M    hildon-widgets/hildon-volumebar-range.c
M    hildon-widgets/hildon-vvolumebar.h
M    hildon-widgets/hildon-volumebar-range.h
M    hildon-widgets/hildon-hvolumebar.c
M    hildon-widgets/hildon-volumebar-private.h
M    hildon-widgets/hildon-hvolumebar.h
M    ChangeLog


U   projects/haf/trunk/hildon-libs/ChangeLog
U   projects/haf/trunk/hildon-libs/hildon-widgets/hildon-hvolumebar.c
U   projects/haf/trunk/hildon-libs/hildon-widgets/hildon-hvolumebar.h
U   projects/haf/trunk/hildon-libs/hildon-widgets/hildon-volumebar-private.h
U   projects/haf/trunk/hildon-libs/hildon-widgets/hildon-volumebar-range.c
U   projects/haf/trunk/hildon-libs/hildon-widgets/hildon-volumebar-range.h
U   projects/haf/trunk/hildon-libs/hildon-widgets/hildon-volumebar.c
U   projects/haf/trunk/hildon-libs/hildon-widgets/hildon-volumebar.h
U   projects/haf/trunk/hildon-libs/hildon-widgets/hildon-vvolumebar.c
U   projects/haf/trunk/hildon-libs/hildon-widgets/hildon-vvolumebar.h

URL: https://stage.maemo.org/viewcvs.cgi?view=rev&root=maemo&rev=2825

/trunk/hildon-libs/