[maemo-commits] [maemo-commits] r12205 - in projects/haf/trunk/gtk+: . gtk

[From: subversion at stage.maemo.org]

Author: xan
Date: 2007-06-08 15:41:18 +0300 (Fri, 08 Jun 2007)
New Revision: 12205

Modified:
   projects/haf/trunk/gtk+/ChangeLog
   projects/haf/trunk/gtk+/gtk/gtkentry.c
Log:
2007-06-08  Xan Lopez  <xan.lopez at nokia.com>

	* gtk/gtkentry.c (gtk_entry_real_activate): remove MAEMO_CHANGES code
	to move-focus in TAB_FORWARD direction. This was supposed to move focus
	to the next editable widget, but it's not working since we moved from 2.6.

	We'll try to do it properly in the IM side now.


Modified: projects/haf/trunk/gtk+/ChangeLog
===================================================================
--- projects/haf/trunk/gtk+/ChangeLog	2007-06-08 12:10:23 UTC (rev 12204)
+++ projects/haf/trunk/gtk+/ChangeLog	2007-06-08 12:41:18 UTC (rev 12205)
@@ -1,3 +1,11 @@
+2007-06-08  Xan Lopez  <xan.lopez at nokia.com>
+
+	* gtk/gtkentry.c (gtk_entry_real_activate): remove MAEMO_CHANGES code
+	to move-focus in TAB_FORWARD direction. This was supposed to move focus
+	to the next editable widget, but it's not working since we moved from 2.6.
+
+	We'll try to do it properly in the IM side now.
+
 2007-06-04  Xan Lopez  <xan.lopez at nokia.com>
 
 	* gtk/gtkwidget.c (gtk_widget_propagate_state): apply patch from

Modified: projects/haf/trunk/gtk+/gtk/gtkentry.c
===================================================================
--- projects/haf/trunk/gtk+/gtk/gtkentry.c	2007-06-08 12:10:23 UTC (rev 12204)
+++ projects/haf/trunk/gtk+/gtk/gtkentry.c	2007-06-08 12:41:18 UTC (rev 12205)
@@ -3197,28 +3197,6 @@
 	    gtk_window_activate_default (window);
 	}
     }
-#ifdef MAEMO_CHANGES
-  else
-    {
-      /* (VKBD) Enter (Enter, GDK_KP_Enter) should accept the field
-       * and move focus to the next editable field.
-       *
-       * If we get here it is often when the user has pressed Enter
-       * and no one handled the event. Another possibility is
-       * application emitting the "activate" signal (in)directly but
-       * that sould be rare.
-       *
-       * FIXME This should probably be removed as it changes the
-       * semantics slightly (be it here or in "key-press-event"
-       * handler) and is probably going to break something.  Though
-       * doing this in the default handler for "activate" should
-       * minimize the impact.  NB#34112
-       */
-      toplevel = gtk_widget_get_toplevel (widget);
-      if (GTK_IS_WINDOW (toplevel))
-        g_signal_emit_by_name (toplevel, "move-focus", GTK_DIR_TAB_FORWARD);
-    }
-#endif /* MAEMO_CHANGES */
 }
 
 static void