[maemo-commits] [maemo-commits] r10488 - in projects/haf/branches/hildon-libs/hildon-1: . src

[From: subversion at stage.maemo.org]

Author: mdk
Date: 2007-03-09 16:00:03 +0200 (Fri, 09 Mar 2007)
New Revision: 10488

Modified:
   projects/haf/branches/hildon-libs/hildon-1/ChangeLog.2
   projects/haf/branches/hildon-libs/hildon-1/src/hildon-helper.c
Log:
Fixing a double free in _set_insenstive_message. Fixes NB#52928.


Modified: projects/haf/branches/hildon-libs/hildon-1/ChangeLog.2
===================================================================
--- projects/haf/branches/hildon-libs/hildon-1/ChangeLog.2	2007-03-09 13:36:08 UTC (rev 10487)
+++ projects/haf/branches/hildon-libs/hildon-1/ChangeLog.2	2007-03-09 14:00:03 UTC (rev 10488)
@@ -1,3 +1,8 @@
+2007-03-09  Michael Dominic Kostrzewa  <michael.kostrzewa at nokia.com> 
+
+	* src/hildon-helper.c: Fixing a double free in
+	_set_insenstive_message. Fixes NB#52928.
+
 2007-03-08  Michael Dominic Kostrzewa  <michael.kostrzewa at nokia.com> 
 
 	* examples/hildon-color-pop-example.c:

Modified: projects/haf/branches/hildon-libs/hildon-1/src/hildon-helper.c
===================================================================
--- projects/haf/branches/hildon-libs/hildon-1/src/hildon-helper.c	2007-03-09 13:36:08 UTC (rev 10487)
+++ projects/haf/branches/hildon-libs/hildon-1/src/hildon-helper.c	2007-03-09 14:00:03 UTC (rev 10488)
@@ -279,17 +279,11 @@
     g_return_if_fail (GTK_IS_WIDGET (widget));
     g_return_if_fail (message != NULL);
 
-    gpointer stored_message;
-
     /* Clean up any previous instance of the insensitive message */
     g_signal_handlers_disconnect_matched (G_OBJECT (widget), G_SIGNAL_MATCH_FUNC,
 					  0, 0, NULL,
 					  G_CALLBACK (show_insensitive_message), NULL);
     
-    stored_message = g_object_get_qdata (G_OBJECT (widget), hildon_helper_insensitive_message_quark ());
-    if (stored_message)
-      g_free (stored_message);
-
     /* We need to dup the string because the pointer might not be valid when the
      insensitive-press signal callback is executed */
     g_object_set_qdata_full (G_OBJECT (widget), hildon_helper_insensitive_message_quark (),