[maemo-commits] [maemo-commits] r13930 - in projects/haf/trunk/hildon-1: . examples src

[From: subversion at stage.maemo.org]

Author: mdk
Date: 2007-09-20 13:50:28 +0300 (Thu, 20 Sep 2007)
New Revision: 13930

Modified:
   projects/haf/trunk/hildon-1/ChangeLog
   projects/haf/trunk/hildon-1/examples/Makefile.am
   projects/haf/trunk/hildon-1/src/hildon-helper.c
Log:
Fixed the leak of the a GList. Fixes: NB#70273.


Modified: projects/haf/trunk/hildon-1/ChangeLog
===================================================================
--- projects/haf/trunk/hildon-1/ChangeLog	2007-09-20 10:38:39 UTC (rev 13929)
+++ projects/haf/trunk/hildon-1/ChangeLog	2007-09-20 10:50:28 UTC (rev 13930)
@@ -1,3 +1,7 @@
+2007-09-20  Johan Bilien  <johan.bilien at nokia.com> 
+
+	* src/hildon-helper.c: Fixed the leak of the a GList. Fixes: NB#70273.
+
 2007-09-18  Michael Dominic Kostrzewa  <michael.kostrzewa at nokia.com> 
 
 	* src/hildon-code-dialog.c: Making the hardcoded WIDTH/HEIGHT values a

Modified: projects/haf/trunk/hildon-1/examples/Makefile.am
===================================================================
--- projects/haf/trunk/hildon-1/examples/Makefile.am	2007-09-20 10:38:39 UTC (rev 13929)
+++ projects/haf/trunk/hildon-1/examples/Makefile.am	2007-09-20 10:50:28 UTC (rev 13930)
@@ -3,6 +3,7 @@
 if BUILD_EXAMPLES
 noinst_PROGRAMS				= hildon-window-example				\
 					  hildon-banner-example				\
+					  hildon-banner-long-example			\
 					  hildon-caption-example			\
 					  hildon-weekday-picker-example			\
 					  hildon-sort-dialog-example			\
@@ -74,6 +75,11 @@
 hildon_banner_example_CFLAGS		= $(HILDON_OBJ_CFLAGS)
 hildon_banner_example_SOURCES		= hildon-banner-example.c
 
+# Hildon banner long
+hildon_banner_long_example_LDADD	= $(HILDON_OBJ_LIBS)
+hildon_banner_long_example_CFLAGS	= $(HILDON_OBJ_CFLAGS)
+hildon_banner_long_example_SOURCES	= hildon-banner-long-example.c
+
 # Hildon caption
 hildon_caption_example_LDADD		= $(HILDON_OBJ_LIBS)
 hildon_caption_example_CFLAGS		= $(HILDON_OBJ_CFLAGS)

Modified: projects/haf/trunk/hildon-1/src/hildon-helper.c
===================================================================
--- projects/haf/trunk/hildon-1/src/hildon-helper.c	2007-09-20 10:38:39 UTC (rev 13929)
+++ projects/haf/trunk/hildon-1/src/hildon-helper.c	2007-09-20 10:50:28 UTC (rev 13930)
@@ -67,9 +67,11 @@
 
     /* Change the style for child widgets */
     if (GTK_IS_CONTAINER (widget)) {
-        GList *iterator = gtk_container_get_children (GTK_CONTAINER (widget));
-        for (iterator = iterator; iterator != NULL; iterator = g_list_next (iterator))
+        GList *iterator, *children;
+        children = gtk_container_get_children (GTK_CONTAINER (widget));
+        for (iterator = children; iterator != NULL; iterator = g_list_next (iterator))
             hildon_change_style_recursive_from_ld (GTK_WIDGET (iterator->data), prev_style, ld);
+        g_list_free (children);
     }
 
     /* gtk_widget_modify_*() emit "style_set" signals, so if we got here from