[maemo-commits] [maemo-commits] r13972 - in projects/haf/trunk/sapwood: . src

From: subversion at stage.maemo.org subversion at stage.maemo.org
Date: Fri Sep 21 12:18:48 EEST 2007
Author: tko
Date: 2007-09-21 12:18:46 +0300 (Fri, 21 Sep 2007)
New Revision: 13972

Modified:
   projects/haf/trunk/sapwood/ChangeLog
   projects/haf/trunk/sapwood/src/sapwood-rc-style.c
Log:
Speed up parsing a little

2007-09-21  Michael Natterer  <mitch at imendio.com>

	* src/sapwood-rc-style.c (sapwood_rc_style_parse): Speed up parsing a
	little by replacing g_list_append with prepend
	(sapwood_rc_style_merge): avoid a memset done by g_list_alloc() by
	using g_list_append() instead (NB#69921)


Modified: projects/haf/trunk/sapwood/ChangeLog
===================================================================
--- projects/haf/trunk/sapwood/ChangeLog	2007-09-21 09:10:48 UTC (rev 13971)
+++ projects/haf/trunk/sapwood/ChangeLog	2007-09-21 09:18:46 UTC (rev 13972)
@@ -1,3 +1,10 @@
+2007-09-21  Michael Natterer  <mitch at imendio.com>
+
+	* src/sapwood-rc-style.c (sapwood_rc_style_parse): Speed up parsing a
+	little by replacing g_list_append with prepend
+	(sapwood_rc_style_merge): avoid a memset done by g_list_alloc() by
+	using g_list_append() instead (NB#69921)
+
 2007-09-17  Tommi Komulainen  <tommi.komulainen at nokia.com>
 
 	* === Release 2.91.11 ===

Modified: projects/haf/trunk/sapwood/src/sapwood-rc-style.c
===================================================================
--- projects/haf/trunk/sapwood/src/sapwood-rc-style.c	2007-09-21 09:10:48 UTC (rev 13971)
+++ projects/haf/trunk/sapwood/src/sapwood-rc-style.c	2007-09-21 09:18:46 UTC (rev 13972)
@@ -798,7 +798,7 @@
       if (token != G_TOKEN_NONE)
 	return token;
       else
-	sapwood_style->img_list = g_list_append(sapwood_style->img_list, img);
+	sapwood_style->img_list = g_list_prepend(sapwood_style->img_list, img);
 
       token = g_scanner_peek_next_token(scanner);
     }
@@ -807,6 +807,8 @@
 
   g_scanner_set_scope(scanner, old_scope);
 
+  sapwood_style->img_list = g_list_reverse(sapwood_style->img_list);
+
   return G_TOKEN_NONE;
 }
 
@@ -831,9 +833,7 @@
 	    {
 	      if (tmp_list2)
 		{
-		  tmp_list2->next = g_list_alloc();
-		  tmp_list2->next->data = tmp_list1->data;
-		  tmp_list2->next->prev = tmp_list2;
+		  tmp_list2 = g_list_append (tmp_list2, tmp_list1->data);
 		  
 		  tmp_list2 = tmp_list2->next;
 		}


More information about the maemo-commits mailing list