[maemo-commits] [maemo-commits] r14110 - in projects/haf/trunk/hildon-desktop: . libhildondesktop

From: subversion at stage.maemo.org subversion at stage.maemo.org
Date: Wed Sep 26 15:20:50 EEST 2007
Author: lucasr
Date: 2007-09-26 15:20:48 +0300 (Wed, 26 Sep 2007)
New Revision: 14110

Modified:
   projects/haf/trunk/hildon-desktop/ChangeLog
   projects/haf/trunk/hildon-desktop/libhildondesktop/hildon-desktop-notification-manager.c
Log:
2007-09-26  Lucas Rocha  <lucas.rocha at nokia.com>

	* libhildondesktop/hildon-desktop-notification-manager.c
	(hildon_desktop_notification_manager_notify): fix memory leak.
	Fixes: NB#70273.


Modified: projects/haf/trunk/hildon-desktop/ChangeLog
===================================================================
--- projects/haf/trunk/hildon-desktop/ChangeLog	2007-09-26 11:02:14 UTC (rev 14109)
+++ projects/haf/trunk/hildon-desktop/ChangeLog	2007-09-26 12:20:48 UTC (rev 14110)
@@ -1,5 +1,11 @@
 2007-09-26  Lucas Rocha  <lucas.rocha at nokia.com>
 
+	* libhildondesktop/hildon-desktop-notification-manager.c
+	(hildon_desktop_notification_manager_notify): fix memory leak.
+	Fixes: NB#70273.
+
+2007-09-26  Lucas Rocha  <lucas.rocha at nokia.com>
+
 	* libhildondesktop/hildon-desktop-popup-window.c
 	(hildon_desktop_popup_window_realize): don't set back pixmap to NULL
 	to make avoid the "partial paint" effect on realize. Fixes: NB#69156.

Modified: projects/haf/trunk/hildon-desktop/libhildondesktop/hildon-desktop-notification-manager.c
===================================================================
--- projects/haf/trunk/hildon-desktop/libhildondesktop/hildon-desktop-notification-manager.c	2007-09-26 11:02:14 UTC (rev 14109)
+++ projects/haf/trunk/hildon-desktop/libhildondesktop/hildon-desktop-notification-manager.c	2007-09-26 12:20:48 UTC (rev 14110)
@@ -1078,6 +1078,7 @@
   GValue *hint;
 #endif
   gchar **actions_copy;
+  gchar *sender = NULL;
   gboolean valid_actions = TRUE;
   gboolean persistent = FALSE;
   gint i;
@@ -1137,6 +1138,8 @@
 
     g_hash_table_foreach (hints, (GHFunc) copy_hash_table_item, hints_copy);
 
+    sender = dbus_g_method_get_sender (context);
+    
     gtk_list_store_set (GTK_LIST_STORE (nm),
 		        &iter,
 		        HD_NM_COL_APPNAME, app_name,
@@ -1150,7 +1153,7 @@
 		        HD_NM_COL_TIMEOUT, timeout,
 			HD_NM_COL_REMOVABLE, TRUE,
 			HD_NM_COL_ACK, FALSE,
-			HD_NM_COL_SENDER, dbus_g_method_get_sender (context),
+			HD_NM_COL_SENDER, sender,
 		        -1);
 
 #ifdef HAVE_SQLITE
@@ -1165,7 +1168,7 @@
 						     actions_copy,
 						     hints_copy,
 						     timeout,
-						     dbus_g_method_get_sender (context));
+						     sender);
     }
 #endif
   }
@@ -1203,7 +1206,9 @@
 		   (GSourceFunc) hildon_desktop_notification_manager_timeout,
 		   GINT_TO_POINTER (id));
   }
-		      
+
+  g_free (sender);
+  
   dbus_g_method_return (context, id);
 
   return TRUE;


More information about the maemo-commits mailing list