[maemo-commits] [maemo-commits] r15743 - in projects/haf/trunk/maemo-launcher: . debian launcher

[From: subversion at stage.maemo.org]

Author: guillem
Date: 2008-07-03 18:47:54 +0300 (Thu, 03 Jul 2008)
New Revision: 15743

Modified:
   projects/haf/trunk/maemo-launcher/ChangeLog
   projects/haf/trunk/maemo-launcher/debian/changelog
   projects/haf/trunk/maemo-launcher/launcher/invoker.c
Log:
maemo-invoker: Disable self core dumping before enabling signal forwarding

(Fixes: NB#86713)

Modified: projects/haf/trunk/maemo-launcher/ChangeLog
===================================================================
--- projects/haf/trunk/maemo-launcher/ChangeLog	2008-07-03 15:47:49 UTC (rev 15742)
+++ projects/haf/trunk/maemo-launcher/ChangeLog	2008-07-03 15:47:54 UTC (rev 15743)
@@ -1,5 +1,11 @@
 2008-07-03  Guillem Jover  <guillem.jover at nokia.com>
 
+	* launcher/invoker.c (disable_self_core_dump): New function.
+	(main): Call disable_self_core_dump before setting up the signal
+	forwarder.
+
+2008-07-03  Guillem Jover  <guillem.jover at nokia.com>
+
 	* configure.ac: Bump version to 0.31~.
 
 2008-05-29  Guillem Jover  <guillem.jover at nokia.com>

Modified: projects/haf/trunk/maemo-launcher/debian/changelog
===================================================================
--- projects/haf/trunk/maemo-launcher/debian/changelog	2008-07-03 15:47:49 UTC (rev 15742)
+++ projects/haf/trunk/maemo-launcher/debian/changelog	2008-07-03 15:47:54 UTC (rev 15743)
@@ -5,6 +5,8 @@
     approach.
   * Let's take quality seriously by disabling the application crash
     notifications. (Fixes: NB#86713)
+  * Disable self core dumping on maemo-invoker just before enabling signal
+    forwarding. (Fixes: NB#86713)
 
  -- Guillem Jover <guillem.jover at nokia.com>  Fri, 06 Jun 2008 20:23:48 +0300
 

Modified: projects/haf/trunk/maemo-launcher/launcher/invoker.c
===================================================================
--- projects/haf/trunk/maemo-launcher/launcher/invoker.c	2008-07-03 15:47:49 UTC (rev 15742)
+++ projects/haf/trunk/maemo-launcher/launcher/invoker.c	2008-07-03 15:47:54 UTC (rev 15743)
@@ -30,6 +30,7 @@
 #include <signal.h>
 #include <sys/socket.h>
 #include <sys/un.h>
+#include <sys/time.h>
 #include <sys/resource.h>
 #include <unistd.h>
 #include <errno.h>
@@ -86,6 +87,15 @@
   sigs_set(&sig);
 }
 
+static void
+disable_self_core_dump(void)
+{
+  struct rlimit rlim = { 0, 0 };
+
+  if (setrlimit(RLIMIT_CORE, &rlim) != 0)
+    warning("could not disable self core dumping");
+}
+
 static bool
 invoke_recv_ack(int fd)
 {
@@ -423,6 +433,11 @@
     debug("waiting for invoked program to exit\n");
 
     invoker_recv_pid(fd);
+
+    /* We should disable self core dumps as late as possible, so that we have
+     * a chance to dump on our own bugs. */
+    disable_self_core_dump();
+
     sigs_init();
     status = invoker_recv_exit(fd);
     sigs_restore();