[maemo-commits] [maemo-commits] r16106 - in projects/haf/branches/hildon-thumbnail/daemonize: . daemon daemon/plugins thumbs

From: subversion at stage.maemo.org subversion at stage.maemo.org
Date: Fri Sep 12 15:34:48 EEST 2008
Author: pvanhoof
Date: 2008-09-12 15:34:46 +0300 (Fri, 12 Sep 2008)
New Revision: 16106

Modified:
   projects/haf/branches/hildon-thumbnail/daemonize/ChangeLog
   projects/haf/branches/hildon-thumbnail/daemonize/daemon/hildon-thumbnail-daemon.c
   projects/haf/branches/hildon-thumbnail/daemonize/daemon/manager.c
   projects/haf/branches/hildon-thumbnail/daemonize/daemon/plugins/exec-plugin.c
   projects/haf/branches/hildon-thumbnail/daemonize/thumbs/hildon-thumbnail-factory.c
   projects/haf/branches/hildon-thumbnail/daemonize/thumbs/thumber-register.c
Log:
2008-09-12  Philip Van Hoof  <pvanhoof at gnome.org>

	* thumbs/hildon-thumbnail-factory.c
	* thumbs/thumber-register.c
	* daemon/hildon-thumbnail-daemon.c
	* daemon/plugins/exec-plugin.c
	* daemon/manager.c: Removed warnings



Modified: projects/haf/branches/hildon-thumbnail/daemonize/ChangeLog
===================================================================
--- projects/haf/branches/hildon-thumbnail/daemonize/ChangeLog	2008-09-12 12:23:33 UTC (rev 16105)
+++ projects/haf/branches/hildon-thumbnail/daemonize/ChangeLog	2008-09-12 12:34:46 UTC (rev 16106)
@@ -1,5 +1,13 @@
 2008-09-12  Philip Van Hoof  <pvanhoof at gnome.org>
 
+	* thumbs/hildon-thumbnail-factory.c
+	* thumbs/thumber-register.c
+	* daemon/hildon-thumbnail-daemon.c
+	* daemon/plugins/exec-plugin.c
+	* daemon/manager.c: Removed warnings
+
+2008-09-12  Philip Van Hoof  <pvanhoof at gnome.org>
+
 	* debian/hildon-thumbnail.install
 	* thumbs/Makefile.am: Packaging work
 

Modified: projects/haf/branches/hildon-thumbnail/daemonize/daemon/hildon-thumbnail-daemon.c
===================================================================
--- projects/haf/branches/hildon-thumbnail/daemonize/daemon/hildon-thumbnail-daemon.c	2008-09-12 12:23:33 UTC (rev 16105)
+++ projects/haf/branches/hildon-thumbnail/daemonize/daemon/hildon-thumbnail-daemon.c	2008-09-12 12:34:46 UTC (rev 16106)
@@ -53,8 +53,7 @@
 		Manager *manager;
 		Thumbnailer *thumbnailer;
 		DBusGProxy *manager_proxy;
-		GStrv supported;
-		guint i = 0, y = 0;
+		guint y = 0;
 		gboolean cropping;
 		const gchar *plugins[3] = { "gdkpixbuf", "exec", NULL};
 		/* TODO: dynamically load plugins, and detect when new ones get

Modified: projects/haf/branches/hildon-thumbnail/daemonize/daemon/manager.c
===================================================================
--- projects/haf/branches/hildon-thumbnail/daemonize/daemon/manager.c	2008-09-12 12:23:33 UTC (rev 16105)
+++ projects/haf/branches/hildon-thumbnail/daemonize/daemon/manager.c	2008-09-12 12:34:46 UTC (rev 16106)
@@ -428,7 +428,6 @@
 manager_init (Manager *object)
 {
 	ManagerPrivate *priv = MANAGER_GET_PRIVATE (object);
-	GFile *file1, *file2;
 
 	priv->mutex = g_mutex_new ();
 	priv->handlers = g_hash_table_new_full (g_str_hash, g_str_equal,

Modified: projects/haf/branches/hildon-thumbnail/daemonize/daemon/plugins/exec-plugin.c
===================================================================
--- projects/haf/branches/hildon-thumbnail/daemonize/daemon/plugins/exec-plugin.c	2008-09-12 12:23:33 UTC (rev 16105)
+++ projects/haf/branches/hildon-thumbnail/daemonize/daemon/plugins/exec-plugin.c	2008-09-12 12:34:46 UTC (rev 16106)
@@ -78,7 +78,7 @@
 	guint len, i, off = 0, z, in_len = total;
 	guint large_len, normal_len, cropped_len, mime_len, 
 		mtime_len, cropping_len, mime_at_len, uri_len;
-	gchar *s_mtime = g_strdup_printf ("%lu", mtime);
+	gchar *s_mtime = g_strdup_printf ("%u", mtime);
 	gchar *ret;
 
 
@@ -245,9 +245,6 @@
 		gchar *large = NULL, 
 		      *normal = NULL, 
 		      *cropped = NULL;
-		gchar *olarge = NULL, 
-		      *onormal = NULL, 
-		      *ocropped = NULL;
 		gchar *exec = NULL;
 		gchar *mime_type = NULL;
 		gchar *mime_type_at = NULL;
@@ -257,7 +254,6 @@
 		guint64 mtime;
 		gchar *r_exec = NULL;
 		gchar *slash_pos;
-		gchar *cmd_dir, *cmd_path;
 
 		file = g_file_new_for_uri (uri);
 		info = g_file_query_info (file,

Modified: projects/haf/branches/hildon-thumbnail/daemonize/thumbs/hildon-thumbnail-factory.c
===================================================================
--- projects/haf/branches/hildon-thumbnail/daemonize/thumbs/hildon-thumbnail-factory.c	2008-09-12 12:23:33 UTC (rev 16105)
+++ projects/haf/branches/hildon-thumbnail/daemonize/thumbs/hildon-thumbnail-factory.c	2008-09-12 12:34:46 UTC (rev 16106)
@@ -543,7 +543,7 @@
 GdkPixbuf* 
 hildon_thumber_create_empty_pixbuf (void)
 {
-	gdk_pixbuf_new(GDK_COLORSPACE_RGB, FALSE, 8, 1, 1);
+	return gdk_pixbuf_new(GDK_COLORSPACE_RGB, FALSE, 8, 1, 1);
 }
 
 GQuark 

Modified: projects/haf/branches/hildon-thumbnail/daemonize/thumbs/thumber-register.c
===================================================================
--- projects/haf/branches/hildon-thumbnail/daemonize/thumbs/thumber-register.c	2008-09-12 12:23:33 UTC (rev 16105)
+++ projects/haf/branches/hildon-thumbnail/daemonize/thumbs/thumber-register.c	2008-09-12 12:34:46 UTC (rev 16106)
@@ -26,6 +26,7 @@
 #include <string.h>
 
 #include <glib.h>
+#include <glib-object.h>
 
 
 #define CONVERT_CMD BIN_PATH G_DIR_SEPARATOR_S "hildon-thumbnailer-wrap.sh \"%s\" \"{uri}\" \"{large}\" \"{normal}\" \"{cropped}\" \"{mime_at}\" \"{mime}\""
@@ -50,8 +51,6 @@
 {
 	gchar *config = g_build_filename (g_get_user_config_dir (), "hildon-thumbnailer", "exec-plugin.conf", NULL);
 	GKeyFile *keyfile;
-	gchar **mimetypes;
-	guint i = 0, length;
 	gchar *r_cmd;
 
 	gchar *d = g_build_filename (g_get_user_config_dir (), "hildon-thumbnailer", NULL);
@@ -112,8 +111,6 @@
 {
 	gchar *config = g_build_filename (g_get_user_config_dir (), "hildon-thumbnailer", "exec-plugin.conf", NULL);
 	GKeyFile *keyfile;
-	gchar **mimetypes;
-	guint i = 0, length;
 
 	keyfile = g_key_file_new ();
 
@@ -190,9 +187,8 @@
 	keyfile = g_key_file_new ();
 
 	if (g_key_file_load_from_file (keyfile, config, G_KEY_FILE_NONE, NULL)) {
-		guint length, i, z;
+		guint z;
 		gchar **o;
-		gchar **mimetypes = NULL;
 
 		o = g_key_file_get_string_list (keyfile, "Hildon Thumbnailer", "MimeTypes", 
 							&length, NULL);


More information about the maemo-commits mailing list