[maemo-commits] [maemo-commits] r16248 - projects/haf/branches/hildon-thumbnail/daemonize/daemon

From: subversion at stage.maemo.org subversion at stage.maemo.org
Date: Fri Sep 26 16:19:41 EEST 2008
Author: pvanhoof
Date: 2008-09-26 16:19:41 +0300 (Fri, 26 Sep 2008)
New Revision: 16248

Modified:
   projects/haf/branches/hildon-thumbnail/daemonize/daemon/albumart.c
Log:
Added some TODO items

Modified: projects/haf/branches/hildon-thumbnail/daemonize/daemon/albumart.c
===================================================================
--- projects/haf/branches/hildon-thumbnail/daemonize/daemon/albumart.c	2008-09-26 13:07:59 UTC (rev 16247)
+++ projects/haf/branches/hildon-thumbnail/daemonize/daemon/albumart.c	2008-09-26 13:19:41 UTC (rev 16248)
@@ -172,40 +172,48 @@
 
 	hildon_thumbnail_util_get_albumart_path (albumartist, uri, &path);
 
+
 	if (!g_file_test (path, G_FILE_TEST_EXISTS)) {
+		GList *proxies, *copy;
+		gboolean handled = FALSE;
 
-		/* TODO */
-		GList *proxies = albumart_manager_get_handlers (priv->manager);
-		GList *copy = proxies;
+		// TODO: Perform copy from embedded (in uri) to path
+		// TODO: Perform heuristics from uri to path
 
-		while (copy) {
-			DBusGProxy *proxy = copy->data;
-			GError *error = NULL;
+		if (!handled) {
 
-			keep_alive ();
+			proxies = albumart_manager_get_handlers (priv->manager);
+			copy = proxies;
 
-			// PROVIDER_INTERFACE
-			dbus_g_proxy_call (proxy, "Fetch", &error, 
-					   G_TYPE_STRING, albumartist, uri,
-					   G_TYPE_INVALID, 
-					   G_TYPE_INVALID);
+			while (copy) {
+				DBusGProxy *proxy = copy->data;
+				GError *error = NULL;
 
-			keep_alive ();
+				keep_alive ();
 
-			g_object_unref (proxy);
+				// PROVIDER_INTERFACE
+				dbus_g_proxy_call (proxy, "Fetch", &error, 
+						   G_TYPE_STRING, albumartist, uri,
+						   G_TYPE_INVALID, 
+						   G_TYPE_INVALID);
 
-			if (error) {
-				g_signal_emit (task->object, signals[ERROR_SIGNAL],
-					       0, task->num, 1, error->message);
-				g_clear_error (&error);
-			} else
-				g_signal_emit (task->object, signals[READY_SIGNAL], 
-					       0, albumartist, uri, path);
+				keep_alive ();
 
-			copy = g_list_next (copy);
-		} 
+				g_object_unref (proxy);
 
-		g_list_free (proxies);
+				if (error) {
+					g_signal_emit (task->object, signals[ERROR_SIGNAL],
+						       0, task->num, 1, error->message);
+					g_clear_error (&error);
+				} else
+					g_signal_emit (task->object, signals[READY_SIGNAL], 
+						       0, albumartist, uri, path);
+
+				copy = g_list_next (copy);
+			} 
+
+			g_list_free (proxies);
+		}
 	}
 
 	g_free (path);


More information about the maemo-commits mailing list