[maemo-commits] [maemo-commits] r18922 - in projects/haf/trunk/libmatchbox2: . matchbox/core

[From: subversion at stage.maemo.org]

Author: kihamala
Date: 2009-07-21 15:02:59 +0300 (Tue, 21 Jul 2009)
New Revision: 18922

Modified:
   projects/haf/trunk/libmatchbox2/ChangeLog
   projects/haf/trunk/libmatchbox2/matchbox/core/mb-wm-main-context.c
Log:
possible crash fix: if event handler was freed in an event handler, the caller
could not notice it because it wasn't memset to zero.



Modified: projects/haf/trunk/libmatchbox2/ChangeLog
===================================================================
--- projects/haf/trunk/libmatchbox2/ChangeLog	2009-07-21 10:09:22 UTC (rev 18921)
+++ projects/haf/trunk/libmatchbox2/ChangeLog	2009-07-21 12:02:59 UTC (rev 18922)
@@ -1,3 +1,10 @@
+2009-07-21  Kimmo Hämäläinen  <kimmo.hamalainen at nokia.com>
+
+	* matchbox/core/mb-wm-main-context.c
+	(mb_wm_main_context_x_event_handler_remove): memset the list item with
+	zeros before freeing it so that call_handlers_for_event can see that
+	it's not valid anymore.
+
 2009-07-20  Kimmo Hämäläinen  <kimmo.hamalainen at nokia.com>
 
 	Release 0.2.48

Modified: projects/haf/trunk/libmatchbox2/matchbox/core/mb-wm-main-context.c
===================================================================
--- projects/haf/trunk/libmatchbox2/matchbox/core/mb-wm-main-context.c	2009-07-21 10:09:22 UTC (rev 18921)
+++ projects/haf/trunk/libmatchbox2/matchbox/core/mb-wm-main-context.c	2009-07-21 12:02:59 UTC (rev 18922)
@@ -608,6 +608,7 @@
 	  if (next)
 	    next->prev = prev;
 
+          memset (info, 0, sizeof(*info));
 	  free (info);
 	  free (l);