[maemo-commits] [maemo-commits] r19002 - in projects/haf/trunk/libmatchbox2: . matchbox/core

[From: subversion at stage.maemo.org]

Author: aendrodi
Date: 2009-07-28 15:30:09 +0300 (Tue, 28 Jul 2009)
New Revision: 19002

Modified:
   projects/haf/trunk/libmatchbox2/ChangeLog
   projects/haf/trunk/libmatchbox2/matchbox/core/mb-wm-client-base.c
   projects/haf/trunk/libmatchbox2/matchbox/core/mb-wm-util.c
Log:
	Diagnostic improvements.

	* matchbox/core/mb-wm-util.c (error_handler):
	  g_debug() more information in case of an XErrorEvent.
	* matchbox/core/mb-wm-client-base.c (mb_wm_client_base_realize):
	  Leave a note that we're screwing up if we're about to
	  create 0x0 windows (a.k.a. "invisible windows" symptom).


Modified: projects/haf/trunk/libmatchbox2/ChangeLog
===================================================================
--- projects/haf/trunk/libmatchbox2/ChangeLog	2009-07-28 12:22:03 UTC (rev 19001)
+++ projects/haf/trunk/libmatchbox2/ChangeLog	2009-07-28 12:30:09 UTC (rev 19002)
@@ -1,5 +1,15 @@
-2009-07-27  Adam Endrodi  <adam.endrodi at blumsoft.eu>
+2009-07-28  Adam Endrodi  <adam.endrodi at blumsoft.eu>
 
+	Diagnostic improvements.
+
+	* matchbox/core/mb-wm-util.c (error_handler):
+	  g_debug() more information in case of an XErrorEvent.
+	* matchbox/core/mb-wm-client-base.c (mb_wm_client_base_realize):
+	  Leave a note that we're screwing up if we're about to
+	  create 0x0 windows (a.k.a. "invisible windows" symptom).
+
+2009-07-28  Adam Endrodi  <adam.endrodi at blumsoft.eu>
+
 	* matchbox/core/mb-window-manager.c (mb_wm_handle_property_notify):
 	  Detect changes to MBWM_ATOM_MAEMO_SUPPRESS_ROOT_RECONFIGURATION
 	  via property state rather than a toggle.  Requires newer

Modified: projects/haf/trunk/libmatchbox2/matchbox/core/mb-wm-client-base.c
===================================================================
--- projects/haf/trunk/libmatchbox2/matchbox/core/mb-wm-client-base.c	2009-07-28 12:22:03 UTC (rev 19001)
+++ projects/haf/trunk/libmatchbox2/matchbox/core/mb-wm-client-base.c	2009-07-28 12:30:09 UTC (rev 19002)
@@ -186,6 +186,10 @@
     {
       if (client->xwin_frame == None)
 	{
+          if (!client->frame_geometry.width || !client->frame_geometry.height)
+            g_critical ("i'm [not] gonna create 0x0 frame window and play "
+                        "hide and catch with you, have a good time");
+
 #if ENABLE_COMPOSITE
 	  if (mb_wm_client_is_argb32 (client))
 	    {
@@ -210,9 +214,7 @@
 	  else
 #endif
 	    {
-	      /* Decorated, with no frame, and
-	       * non-ARGB32 or no compositor
-	       */
+	      /* Decorated, with no frame, and non-ARGB32 or no compositor */
 	      client->xwin_frame
 		= XCreateWindow(wm->xdpy, wm->root_win->xwindow,
 				client->frame_geometry.x,
@@ -228,7 +230,10 @@
 	      mb_wm_rename_window (wm, client->xwin_frame, "nonalphaframe");
 	    }
         }
-        
+
+      g_debug("frame for window 0x%lx is 0x%lx",
+              client->window->xwindow, client->xwin_frame);
+
       /*
        * Assume geometry sync will fix this up correctly
        * together with any decoration creation. Layout

Modified: projects/haf/trunk/libmatchbox2/matchbox/core/mb-wm-util.c
===================================================================
--- projects/haf/trunk/libmatchbox2/matchbox/core/mb-wm-util.c	2009-07-28 12:22:03 UTC (rev 19001)
+++ projects/haf/trunk/libmatchbox2/matchbox/core/mb-wm-util.c	2009-07-28 12:30:09 UTC (rev 19002)
@@ -12,7 +12,9 @@
 	      XErrorEvent *error)
 {
   TrappedErrorCode = error->error_code;
-  g_debug("X error %d", TrappedErrorCode);
+  g_debug("X error %d, window: 0x%lx, req: %d, minor: %d",
+          error->error_code, error->resourceid,
+          error->request_code, error->minor_code);
   return 0;
 }