[maemo-commits] [maemo-commits] r18760 - in projects/haf/trunk/libmatchbox2: . matchbox/core

[From: subversion at stage.maemo.org]

Author: aendrodi
Date: 2009-06-18 17:28:01 +0300 (Thu, 18 Jun 2009)
New Revision: 18760

Modified:
   projects/haf/trunk/libmatchbox2/ChangeLog
   projects/haf/trunk/libmatchbox2/matchbox/core/mb-wm-client-base.c
Log:
	* matchbox/core/mb-wm-client-base.c (mb_wm_client_base_display_sync):
	  When doing a fullscreen sync don't attempt to re-reparent an
	  undecorated client to the root window.  Undecorated clients
	  don't have frames and are reparented when they are realized.
	  The point is not to bump skip_unmaps because that never comes
	  (sinece X won't re-reparent to the same window) and then we
	  will lose an unmap in the cmgr.


Modified: projects/haf/trunk/libmatchbox2/ChangeLog
===================================================================
--- projects/haf/trunk/libmatchbox2/ChangeLog	2009-06-18 14:05:18 UTC (rev 18759)
+++ projects/haf/trunk/libmatchbox2/ChangeLog	2009-06-18 14:28:01 UTC (rev 18760)
@@ -1,3 +1,13 @@
+2009-06-18  Adam Endrodi  <adam.endrodi at blumsoft.eu>
+
+	* matchbox/core/mb-wm-client-base.c (mb_wm_client_base_display_sync):
+	  When doing a fullscreen sync don't attempt to re-reparent an
+	  undecorated client to the root window.  Undecorated clients
+	  don't have frames and are reparented when they are realized.
+	  The point is not to bump skip_unmaps because that never comes
+	  (sinece X won't re-reparent to the same window) and then we
+	  will lose an unmap in the cmgr.
+
 2009-06-17  Thomas Thurman  <thomas.thurman at collabora.co.uk>
 
 	NB#119560 Hiding a window affects the visibility of

Modified: projects/haf/trunk/libmatchbox2/matchbox/core/mb-wm-client-base.c
===================================================================
--- projects/haf/trunk/libmatchbox2/matchbox/core/mb-wm-client-base.c	2009-06-18 14:05:18 UTC (rev 18759)
+++ projects/haf/trunk/libmatchbox2/matchbox/core/mb-wm-client-base.c	2009-06-18 14:28:01 UTC (rev 18760)
@@ -553,8 +553,8 @@
 		  
 		}
 	    }
-	  else
-	    {
+	  else if (!client->window->undecorated)
+	    { /* Undecorated windows are always parented at the root. */
 	      client->skip_unmaps++;
               MB_WM_DBG_SKIP_UNMAPS (client);
 	      XReparentWindow(wm->xdpy, MB_WM_CLIENT_XWIN(client),
@@ -562,6 +562,8 @@
 			      client->window->geometry.x,
 			      client->window->geometry.y);
 	    }
+          /* What if the window has changed its undecoratedness hint?
+           * We have never supported it, it seems. */
 	}
 
       mb_wm_client_request_geometry (