[maemo-commits] [maemo-commits] r17757 - in projects/haf/trunk/libmatchbox2: . matchbox/core

[From: subversion at stage.maemo.org]

Author: kihamala
Date: 2009-03-20 13:42:48 +0200 (Fri, 20 Mar 2009)
New Revision: 17757

Modified:
   projects/haf/trunk/libmatchbox2/ChangeLog
   projects/haf/trunk/libmatchbox2/matchbox/core/mb-wm-decor.c
Log:
disable dragging windows around, should fix a crash


Modified: projects/haf/trunk/libmatchbox2/ChangeLog
===================================================================
--- projects/haf/trunk/libmatchbox2/ChangeLog	2009-03-20 11:36:25 UTC (rev 17756)
+++ projects/haf/trunk/libmatchbox2/ChangeLog	2009-03-20 11:42:48 UTC (rev 17757)
@@ -1,3 +1,11 @@
+2009-03-20  Kimmo Hämäläinen  <kimmo.hamalainen at nokia.com>
+
+	* matchbox/core/mb-wm-decor.c (mb_wm_decor_release_handler,
+	mb_wm_decor_press_handler): Commented out since dragging windows
+	around is not supported and since NB#101901 reports a crash related to
+	this code.
+	(mb_wm_decor_sync_window): Do not install the press handler.
+
 2009-03-20  Adam Endrodi  <adam.endrodi at blumsoft.eu>
 
 	* matchbox/comp-mgr/mb-wm-comp-mgr.c:
@@ -14,11 +22,12 @@
 
 2009-03-19  Adam Endrodi  <adam.endrodi at blumsoft.eu>
 
-	* matchbox/core/mb-wm-client-window.c (mb_wm_client_window_sync_properties):
-	  Regression fix.  When the the window name property changed but we
-	  failed to get the new value the old MBWMClientWindow::name field
-	  left dangling.  Fixes a crash with modest's new account wizard,
-	  which tries to set the dialog's title when it is cancelled.
+	* matchbox/core/mb-wm-client-window.c
+	(mb_wm_client_window_sync_properties):
+	Regression fix.  When the the window name property changed but we
+	failed to get the new value the old MBWMClientWindow::name field
+	left dangling.  Fixes a crash with modest's new account wizard,
+	which tries to set the dialog's title when it is cancelled.
 
 2009-03-18  Thomas Thurman  <thomas.thurman at collabora.co.uk>
 

Modified: projects/haf/trunk/libmatchbox2/matchbox/core/mb-wm-decor.c
===================================================================
--- projects/haf/trunk/libmatchbox2/matchbox/core/mb-wm-decor.c	2009-03-20 11:36:25 UTC (rev 17756)
+++ projects/haf/trunk/libmatchbox2/matchbox/core/mb-wm-decor.c	2009-03-20 11:42:48 UTC (rev 17757)
@@ -200,6 +200,7 @@
 static Bool
 mb_wm_decor_reparent (MBWMDecor *decor);
 
+#if 0
 static Bool
 mb_wm_decor_release_handler (XButtonEvent    *xev,
 			     void            *userdata)
@@ -320,6 +321,7 @@
 
   return retval;
 }
+#endif
 
 static Bool
 mb_wm_decor_sync_window (MBWMDecor *decor)
@@ -377,6 +379,9 @@
 		            (MBWMListForEachCB)mb_wm_decor_button_sync_window,
 			    NULL);
 
+#if 0 /* we don't need to support dragging windows around, and there was
+         a crash in mb_wm_decor_press_handler, so this is disabled for now */
+
       /*
        * If this is a decor with buttons, then we install button press handler
        * so we can drag the window, if it is movable.
@@ -395,6 +400,7 @@
 			        (MBWMXEventFunc)mb_wm_decor_press_handler,
 			        decor);
 	}
+#endif
 
       return mb_wm_decor_reparent (decor);
     }