[maemo-commits] [maemo-commits] r17762 - in projects/haf/trunk/libmatchbox2: . matchbox/core

From: subversion at stage.maemo.org subversion at stage.maemo.org
Date: Fri Mar 20 15:53:56 EET 2009
Author: kihamala
Date: 2009-03-20 15:53:55 +0200 (Fri, 20 Mar 2009)
New Revision: 17762

Modified:
   projects/haf/trunk/libmatchbox2/ChangeLog
   projects/haf/trunk/libmatchbox2/matchbox/core/mb-wm-decor.c
Log:
fix a memory leak


Modified: projects/haf/trunk/libmatchbox2/ChangeLog
===================================================================
--- projects/haf/trunk/libmatchbox2/ChangeLog	2009-03-20 13:05:30 UTC (rev 17761)
+++ projects/haf/trunk/libmatchbox2/ChangeLog	2009-03-20 13:53:55 UTC (rev 17762)
@@ -1,3 +1,8 @@
+2009-03-20  Kimmo Hämäläinen  <kimmo.hamalainen at nokia.com>
+
+	* matchbox/core/mb-wm-decor.c (mb_wm_decor_button_press_handler): Fix
+	a memory leak in freeing the list of transients.
+
 2009-03-20  Adam Endrodi  <adam.endrodi at blumsoft.eu>
 
 	* matchbox/comp-mgr/mb-wm-comp-mgr.c:

Modified: projects/haf/trunk/libmatchbox2/matchbox/core/mb-wm-decor.c
===================================================================
--- projects/haf/trunk/libmatchbox2/matchbox/core/mb-wm-decor.c	2009-03-20 13:05:30 UTC (rev 17761)
+++ projects/haf/trunk/libmatchbox2/matchbox/core/mb-wm-decor.c	2009-03-20 13:53:55 UTC (rev 17762)
@@ -774,7 +774,7 @@
   MBWMDecorButton *button = (MBWMDecorButton *)userdata;
   MBWMDecor       *decor  = button->decor;
   MBWindowManager *wm = decor->parent_client->wmref;
-  MBWMList        *l = NULL;
+  MBWMList        *transients = NULL;
   Bool             retval = True;
 
   mb_wm_object_ref (MB_WM_OBJECT(button));
@@ -782,8 +782,10 @@
   if (xev->window == decor->xwin)
     {
       int xmin, ymin, xmax, ymax;
-      l = mb_wm_client_get_transients (decor->parent_client);
+      MBWMList *l;
 
+      transients = l = mb_wm_client_get_transients (decor->parent_client);
+
       /* Ignore events on the main window decor if transients other than
        * input methods are present
        */
@@ -982,7 +984,7 @@
     }
 
  done:
-  mb_wm_util_list_free (l);
+  mb_wm_util_list_free (transients);
   mb_wm_object_unref (MB_WM_OBJECT(button));
   return retval;
 }


More information about the maemo-commits mailing list