[maemo-community] [maemo2midgard] status update

[From: Henri Bergius]

Hi, and thanks for the update. Things are starting to look good...

On Dec 13, 2006, at 21:06, Ferenc Szekely wrote:
> I found a bug related to folder deletion:
> Steps to reproduce:
> -delete a folder (but remember its URL)
> -add a folder to the same place where the previous folder was defined
> -input the same URL as the previously deleted folder had to the  
> "url" field
> -click save
>
> Result:
> the folder can not be saved, because it already exists.
>
> Expected result:
> Midgard saves the folder and it appears in the navigation.

I think I found the cause of this issue: Folder creation checks  
whether a folder with the same name exists using a deprecated API  
function mgd_get_topic_by_name(), which probably is unaware of the  
metadata_deleted flag. Therefore folders that have been deleted but  
not purged

Should be easy fix. Change line 484 of lib/midcom/admin/folder/ 
folder_management.php from:

if (mgd_get_topic_by_name($this->_topic->id, $name))

to:
$qb = midcom_db_topic::new_query_builder();
$qb->add_constraint('up', '=', $this->_topic->id);
$qb->add_constraint('name', '=', $name);
if ($qb->count() > 0)

I'll fix this in SVN tomorrow.

/Henri

Henri Bergius
Consultant Partner, Nemein
henri.bergius at nemein.com

Midgard CMS
www.midgard-project.org