[maemo-developers] [maemo-developers] Re: The mmap stuff definitely needs more eyes!

[From: Philip Van Hoof]

Hi there,

This one works on the Nokia 770 device!

http://pvanhoof.be/files/camel_folder_summary_with_mmap_fixes11_data_alignment04.diff

So my real target has finally been reached. Using this stuff, it should
be possible to display huge folders using tinymail on a Nokia 770. 

With huge I mean: I'm expecting to support more than 20,000 headers per
folder. I don't know .. in theory it should even work with 100,000 or
more headers. But there's theory and reality. Lets test?

ps. It's of course going to take a while to receive the summary of such
a folder over wifi. 
ps. I only tested this (on the device) with the imap implementation.
ps. Other people, please test this?


On Mon, 2006-07-17 at 20:47 +0200, Philip Van Hoof wrote:
> Eeeek. Look at what I just found in my own patches!!
> 
> static CamelMessageInfo *
> message_info_load (CamelFolderSummary *s, FILE *in)
> {
> 	CamelMessageInfo *info;
> 	CamelImapMessageInfo *iinfo;
> 
> 	info = camel_imap_summary_parent->message_info_load (s, in);
> 
> 	if (info) {
> 		unsigned char* ptrchr = s->filepos;
> 		ptrchr = camel_file_util_mmap_decode_uint32 (ptrchr, &iinfo->server_flags, FALSE);
> 		s->filepos = ptrchr;
> 		label_to_flags(iinfo);
> 	}
> 
> 	return info;
> }
> 
> 
> The "iinfo" is simply never assigned, yet being used! Eeeeeeek! *scared
> by my own mistakes now*. Very strange that didn't crash and burn on x86
> but does crash on ARM.


-- 
Philip Van Hoof, software developer at x-tend 
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
work: vanhoof at x-tend dot be 
http://www.pvanhoof.be - http://www.x-tend.be