[maemo-developers] sapwood bug

[From: Li, Frank]

Cheers, Xan:

	Thank you for your response. 
	Do you means you will fix it soon?
	Could you please tell me when you fix it?

Best regards
Frank Li

-----Original Message-----
From: Xan [mailto:xan.lopez at gmail.com] 
Sent: 2007年8月18日 4:12
To: Li, Frank
Cc: maemo-developers at maemo.org; mdz at ubuntu.com; tommi.komulainen at nokia.com
Subject: Re: sapwood big

On 8/7/07, Li, Frank <frank.li at intel.com> wrote:
> Tommi:
>
>         I found a problem at draw_shadow function of sapwood-draw.c
> file.
>         gtk_clist_expose will call gtk_draw_shadow (); Then
> gtk_draw_shadow will call style->draw_shadow, which is point to
> draw_shadow function of sapwood-draw.
>         This will pass widget = NULL to draw_shadow function.  At
> draw_simple_image function, line 249: widget->parent. Segment fault will
> happen because widget is zero at that time.
>         I suggest add
>                 g_return_if_fail(widget != NULL) at begin of draw_shadow
> function.

Hey,
I'm not really Tommi, he will be back from holidays on monday, but anyway:

Seems all the (deprecated) gtk_draw_* functions pass NULL for widget,
area and detail, but considering the gtk_paint_* functions warn that
those parameters might be NULL it wouldn't be too far fetched to check
for it.

Thanks for your report!

Cheers, Xan

>
> Best regards
> Frank Li
> _______________________________________________
> maemo-developers mailing list
> maemo-developers at maemo.org
> https://lists.maemo.org/mailman/listinfo/maemo-developers
>