[maemo-developers] Bugfix in cx3110
From: Steven Walter stevenrwalter at gmail.comDate: Fri Dec 7 05:40:58 EET 2007
- Previous message: Problem making .deb package
 - Next message: Bugfix in cx3110
 - Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
 
While reading through the wireless card driver (what source is
available), I noticed what is almost certainly a bug:
--- sm_drv_ioctl_umac.c~	2007-12-06 22:34:03.000000000 -0500
+++ sm_drv_ioctl_umac.c	2007-12-06 22:34:05.000000000 -0500
@@ -2024,7 +2024,7 @@
 			if (ret < 0)
 				return ret;
 		} else {
-			if (!crypt_info->flags & IW_ENCODE_MODE) {
+			if (!(crypt_info->flags & IW_ENCODE_MODE)) {
 				/* we cannot do anything. Complain. */
 				return -EINVAL;
 			}
--
The old test is equivalent to if (0), which means its not possible
to set the ENCODE_MODE without also setting a key.
-- 
-Steven Walter <stevenrwalter at gmail.com>
Freedom is the freedom to say that 2 + 2 = 4
B2F1 0ECC E605 7321 E818  7A65 FC81 9777 DC28 9E8F 
    - Previous message: Problem making .deb package
 - Next message: Bugfix in cx3110
 - Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
 
