[maemo-developers] Bugfix in cx3110

[From: Kalle Valo]

"ext Steven Walter" <stevenrwalter at gmail.com> writes:

> While reading through the wireless card driver (what source is
> available), I noticed what is almost certainly a bug:
>
> --- sm_drv_ioctl_umac.c~	2007-12-06 22:34:03.000000000 -0500
> +++ sm_drv_ioctl_umac.c	2007-12-06 22:34:05.000000000 -0500
> @@ -2024,7 +2024,7 @@
>  			if (ret < 0)
>  				return ret;
>  		} else {
> -			if (!crypt_info->flags & IW_ENCODE_MODE) {
> +			if (!(crypt_info->flags & IW_ENCODE_MODE)) {
>  				/* we cannot do anything. Complain. */
>  				return -EINVAL;
>  			}
> --
>
> The old test is equivalent to if (0), which means its not possible
> to set the ENCODE_MODE without also setting a key.

You are right. Thanks for telling us.

I noticed that you already filed a bug about, that's really good:

https://bugs.maemo.org/show_bug.cgi?id=2504

For a faster response time I recommend to use cx3110x-devel. I do
follow maemo lists, but very infrequently.

-- 
Kalle Valo