[maemo-developers] hildon dependency on modified gtk+ (was: sbox2 & maemo)

[From: Daniel Stone]

On Thu, Jul 26, 2007 at 06:59:06PM +0300, ext Xan wrote:
> On 7/26/07, Loïc Minier <lool at dooz.org> wrote:
> > On Thu, Jul 26, 2007, Loïc Minier wrote:
> > >  Would be nice if someone could add a #ifdef GDK_CLOSE_ALL_AVAILABLE
> > >  etc. :)
> >
> >  Updating my own question: this function is within "#ifdef
> >  MAEMO_CHANGES"; does that mean that if we start pulling some maemo
> >  changes into Gtk to build hildon (such as the filechooser API which was
> >  mentionned in the thread), then we need the full patch?
> 
> The issue here is: the pc file for hildon-1 hardcodes MAEMO_CHANGES to
> 1, so anything you build on top of it will get that define. This wan
> fine by the time we did it ("if you use hildon you surely want all the
> stuff and certainly you are using our gtk version"), but now that we
> aim to be an upstream project it is no longer acceptable. At the very
> least we should add the MAEMO_CHANGES to the pc file only if hildon-1
> is compiled against our gtk. More rational configuration management is
> badly needed here.

Why not replace MAEMO_CHANGES altogether with a series of more sensible
tests, e.g. 'do I have close_all_available', not 'am I running on
Maemo?'.

Platform tests suck; feature tests are the way forward.

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.maemo.org/pipermail/maemo-developers/attachments/20070727/f7de8ee4/attachment.pgp